Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.diagnostic-languageserver: init at 1.7.1 #97149

Merged
merged 1 commit into from Sep 16, 2020
Merged

nodePackages.diagnostic-languageserver: init at 1.7.1 #97149

merged 1 commit into from Sep 16, 2020

Conversation

felschr
Copy link
Member

@felschr felschr commented Sep 4, 2020

Motivation for this change

Add diagnostic-languageserver, a general purpose language server that integrates with linters.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@felschr
Copy link
Member Author

felschr commented Sep 4, 2020 •
edited

I just ran nixpkgs-review on my changes and joplin fails to build but apparently it already failed before.

@felschr felschr force-pushed the feat/diagnostic-languageserver branch from eac8133 to c8ccaeb Compare September 14, 2020 10:09
@ofborg ofborg bot requested a review from midchildan September 14, 2020 10:18
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/227

@AndersonTorres AndersonTorres merged commit ec5e9b6 into NixOS:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midchildan midchildan midchildan approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felschr @nixos-discourse @midchildan @AndersonTorres