Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sd-local: init at 1.0.5 #97237

Merged
merged 1 commit into from Oct 2, 2020
Merged

sd-local: init at 1.0.5 #97237

merged 1 commit into from Oct 2, 2020

Conversation

midchildan
Copy link
Member

Motivation for this change

sd-local is a command line tool to run screwdriver.cd CI jobs on local development machines.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@midchildan
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Sep 5, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@timokau
Copy link
Member

timokau commented Oct 1, 2020

15 watchers on GitHub, yet no stars. Seems weird 😕

Anyway, pending ofBorgs approval this looks good to me. Not sure why it doesn't run automatically. Please ping me once it has succeeded.

@GrahamcOfBorg build sd-local

@timokau
Copy link
Member

timokau commented Oct 1, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from kalbasit October 1, 2020 18:59
@midchildan
Copy link
Member Author

I'd imagine most people interested in screwdriver.cd would star the main screwdriver repository instead. Anyways, thanks for reviewing!

@timokau timokau merged commit d832ca8 into NixOS:master Oct 2, 2020
@midchildan midchildan deleted the package/sd-local branch October 2, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@midchildan @timokau