Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sparkleshare: Add git-lfs dependency. #97239

Merged
merged 1 commit into from
Sep 7, 2020
Merged

sparkleshare: Add git-lfs dependency. #97239

merged 1 commit into from
Sep 7, 2020
+2 −0

Conversation

kevincox
Copy link
Contributor

@kevincox kevincox commented Sep 5, 2020 •
edited
Loading

SparkleShare failed to sync some repos because it failed to find the git-lfs command.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@kevincox kevincox self-assigned this Sep 5, 2020
@seppeljordan
Copy link
Contributor

I executed nix-review pr 97239 and it executed successfully. Inside the sandbox I ran sparkeshare --help and it worked just fine.

@kevincox
Copy link
Contributor Author

kevincox commented Sep 5, 2020 •
edited
Loading

Yeah, the error reported seems to be unrelated but I'll take a look (or just try rebasing) when I get a chance. It might be a dependency of git-lfs that is already broken?

I can confirm that I am running this build on my NixOS desktop and it is working.

@kevincox
sparkleshare: Add git-lfs dependency.
c626890 
SparkleShare failed to sync some repos because it failed to find the git-lfs command.
@kevincox kevincox force-pushed the kevincox-sparkleshare-lfs branch from 33516f9 to c626890 Compare September 7, 2020 14:22
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 7, 2020
@kevincox kevincox merged commit 13d483a into master Sep 7, 2020
@kevincox kevincox deleted the kevincox-sparkleshare-lfs branch September 7, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kevincox kevincox

Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevincox @seppeljordan