Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbb: fix library install name on macOS #97238

Merged
merged 1 commit into from Sep 6, 2020

Conversation

hannesweisbach
Copy link
Contributor

Motivation for this change

This fixes issue #97014, by adding fixDarwinDylibNames to nativeBuildInputs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 5, 2020
@hannesweisbach
Copy link
Contributor Author

I'd appreciate a hint on why nixpkgs-unstable-jobset fails. Thanks!

@danieldk
Copy link
Contributor

danieldk commented Sep 6, 2020

I'd appreciate a hint on why nixpkgs-unstable-jobset fails. Thanks!

Evaluation of pandoc was broken and fixed in f30e80b. If you rebase your commit on a newer revision, the error should go away.

by adding fixDarwinDylibNames to nativeBuildInputs
@danieldk
Copy link
Contributor

danieldk commented Sep 6, 2020

Not sure if ofborg works at all currently, but here goes nothing:

@ofborg eval

@danieldk danieldk merged commit 2dd4157 into NixOS:master Sep 6, 2020
@hannesweisbach
Copy link
Contributor Author

Thanks!

@hannesweisbach hannesweisbach deleted the macos-tbb branch September 6, 2020 16:16
veprbl pushed a commit that referenced this pull request Sep 9, 2020
by adding fixDarwinDylibNames to nativeBuildInputs

(cherry picked from commit 1488e7d)
cc #97238
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants