Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libfido2: 1.4.0 -> 1.5.0 #97212

Merged
merged 1 commit into from Sep 10, 2020
Merged

libfido2: 1.4.0 -> 1.5.0 #97212

merged 1 commit into from Sep 10, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Sep 5, 2020 •
edited

Motivation for this change

Version update, removed upstreamed patch

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested a review from dtzWill September 5, 2020 14:20
@marsam
Copy link
Contributor

marsam commented Sep 9, 2020 •
edited

please change the base branch to staging

@GrahamcOfBorg eval

@prusnak prusnak changed the base branch from master to staging September 9, 2020 06:10
@prusnak
Copy link
Member Author

prusnak commented Sep 9, 2020

Changed the branch to staging

@marsam marsam merged commit 0a9e3ae into NixOS:staging Sep 10, 2020
@prusnak prusnak deleted the libfido2 branch September 10, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @marsam