Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fontparts: 0.9.2 → 0.9.6 #97211

Merged
merged 1 commit into from Sep 7, 2020
Merged

pythonPackages.fontparts: 0.9.2 → 0.9.6 #97211

merged 1 commit into from Sep 7, 2020

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Sep 5, 2020 •
edited

Motivation for this change

https://github.com/robotools/fontParts/releases/tag/v0.9.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build python3Packages.nototools

drewrisinger
drewrisinger approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

https://github.com/NixOS/nixpkgs/pull/97211
10 packages built:
noto-fonts-emoji python37Packages.afdko python37Packages.fontparts python37Packages.nototools python37Packages.ufoprocessor python38Packages.afdko python38Packages.fontparts python38Packages.nototools python38Packages.ufoprocessor twitter-color-emoji

@seppeljordan
Copy link
Contributor

Executed nix build .#python3Packages.fontparts with flake support enabled on this PR and the package built just fine.

@sternenseemann
Copy link
Member Author

Added.

@sternenseemann sternenseemann changed the title pythonPackages.fontparts: 0.9.2 → 0.9.5 pythonPackages.fontparts: 0.9.2 → 0.9.6 Sep 7, 2020
@sternenseemann
Copy link
Member Author

sternenseemann commented Sep 7, 2020 •
edited

@GrahamcOfBorg build python3Packages.nototools

jonringer
jonringer reviewed Sep 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: this was meant for a different PR

jonringer
jonringer approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97211 1

10 packages built:
  • noto-fonts-emoji
  • python37Packages.afdko
  • python37Packages.fontparts
  • python37Packages.nototools
  • python37Packages.ufoprocessor
  • python38Packages.afdko
  • python38Packages.fontparts
  • python38Packages.nototools
  • python38Packages.ufoprocessor
  • twitter-color-emoji

@jonringer jonringer merged commit 227b210 into NixOS:master Sep 7, 2020
@sternenseemann
Copy link
Member Author

please add openssl to the inputs.

I don't understand. fontparts doesn't import openssl at all?

@jonringer
Copy link
Contributor

jonringer commented Sep 7, 2020 •
edited

I'm trying to do reviews on my laptop, meant it for another PR

Edit: specifically, this was meant for #97349

@sternenseemann
Copy link
Member Author

No problem, just was confused :)

@sternenseemann sternenseemann deleted the fontparts-0.9.5 branch September 7, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sternenseemann @seppeljordan @jonringer @drewrisinger