Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why3: 1.3.1 -> 1.3.2 #97241

Closed
wants to merge 1 commit into from
Closed

why3: 1.3.1 -> 1.3.2 #97241

wants to merge 1 commit into from

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Sep 5, 2020 •
edited

Motivation for this change

New version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

drewrisinger
drewrisinger suggested changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM as-is
  • Suggestion: add meta.changelog = "http://why3.lri.fr/doc/changes.html";
  • Suggestion: change to pull source from Inria Gitlab (see comment)
  • Commits LGTM
  • Builds via nix-review:
https://github.com/NixOS/nixpkgs/pull/97241
2 packages built:
framac why3

pkgs/applications/science/logic/why3/default.nix

src = fetchurl {
url = "https://gforge.inria.fr/frs/download.php/file/38291/why3-1.3.1.tar.gz";
sha256 = "16zcrc60zz2j3gd3ww93z2z9x2jkxb3kr57y8i5rcgmacy7mw3bv";
url = "https://gforge.inria.fr/frs/download.php/file/38366/why3-1.3.2.tar.gz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: switch to using fetchgit with the official Inria GitLab: https://gitlab.inria.fr/why3/why3

Copy link
Contributor

@danieldk danieldk Sep 6, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better, fetchFromGitLab should also work:

fetchFromGitLab {
  domain = "gitlab.inria.fr";
  # The usual attributes.
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned something new!

@stale
Copy link

stale bot commented Apr 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 7, 2021
@vbgl
Copy link
Contributor

vbgl commented Apr 7, 2021

Subsumed by #98441

@vbgl vbgl closed this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

@drewrisinger drewrisinger drewrisinger requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yrashk @vbgl @danieldk @drewrisinger @ryantm