Skip to content

Revert "texinfo: patch cross-build in non-interactive build mode" #97218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "texinfo: patch cross-build in non-interactive build mode" #97218

wants to merge 1 commit into from
+1 −1

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Sep 5, 2020

Non-interactive mode is needed for bootstrapping of darwin stdenv.

This reverts commit 765d3e1.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@FRidh
Revert "texinfo: patch cross-build in non-interactive build mode"
36cf237 
Non-interactive mode is needed for bootstrapping of darwin stdenv.

This reverts commit 765d3e1.
@FRidh
Copy link
Member Author

FRidh commented Sep 5, 2020

This needs testing. cc @NixOS/darwin-maintainers

$ nix build -f https://github.com/FRidh/nixpkgs/archive/texinfo.tar.gz texinfo

or

$ nix-review pr 97218

(but good luck with that one)

This was referenced Sep 5, 2020
Merged
Merged
@FRidh FRidh added the 1.severity: blocker This is preventing another PR or issue from being completed label Sep 5, 2020
@Ericson2314
Copy link
Member

I am confused over how this patch would change anything for darwin bootstrapping as crossBuildTools should be a false either way (since that is native)?

@kampka
Copy link
Contributor

kampka commented Sep 5, 2020

@Ericson2314 In think this PR reverts the wrong part of the PR introducing the issue (#95910). The update to texinfo 6.7 requires libintl.h which is provided by (g-/musl-) libc on Linux. I don't know how that is handled on Darwin but apparently not.

@FRidh FRidh closed this Sep 5, 2020
@vcunat
Copy link
Member

vcunat commented Sep 6, 2020

We have explicit libintl attribute, but I wouldn't dare to try this blindly without testing, as it's during bootstrapping already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: blocker This is preventing another PR or issue from being completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FRidh @Ericson2314 @kampka @vcunat