New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/packetbeat: Add packetbeat module #97152
Open
lejonet
wants to merge
5
commits into
NixOS:master
Choose a base branch
from
lejonet:packetbeat-module
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a packetbeat module so that it can be configured with freeform settings. Made with big help from @aanderse and @infinisil.
@infinisil here's the config again:
|
lejonet
commented
Sep 5, 2020
@lejonet I think this looks good 👍 I'll defer to @infinisil for final approval and merge, though. |
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Nov 19, 2020
lejonet
commented
Nov 19, 2020
…pes.listOf format.type and change the default to a list with mkBefore
lejonet
force-pushed
the
packetbeat-module
branch
from
November 21, 2020 15:30
fc1c8f8
to
4020df1
Compare
infinisil
requested changes
Nov 21, 2020
…s for packetbeat and hardened the service to not require to be run as root
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Jun 3, 2021
Is this ready to be merged ? |
stale
bot
removed
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Nov 25, 2022
stale
bot
added
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
6.topic: nixos
8.has: module (update)
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds a packetbeat module so that it can be configured with
freeform settings. Made with big help from @aanderse and
@infinisil.
We have the packetbeat package in nixpkgs for some time, but no module, so I decided to make one. It uses the freeform module concept.
Remade PR after screwing up the prior PR with a botched rebase.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)