Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home assistant plugins: pysqueezebox and yeelight #97151

Merged
merged 2 commits into from Sep 6, 2020

Conversation

jonringer
Copy link
Contributor

Motivation for this change

closes #96689

used this a template to make a video on how to use git rebase -i to cleanup your git history

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

video can be found https://www.youtube.com/watch?v=OR8Q-4PLalc

@mweinelt
Copy link
Member

mweinelt commented Sep 6, 2020

LGTM.

Result of nixpkgs-review pr 97151 1

5 packages built:
- python27Packages.yeelight
- python37Packages.pysqueezebox
- python37Packages.yeelight
- python38Packages.pysqueezebox
- python38Packages.yeelight

@mweinelt mweinelt merged commit bf72d1b into NixOS:master Sep 6, 2020
@jonringer jonringer deleted the home_assistant_plugins branch September 6, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants