Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cawbird: 1.1.0 -> 1.2.1 #97230

Merged
merged 1 commit into from Sep 21, 2020
Merged

cawbird: 1.1.0 -> 1.2.1 #97230

merged 1 commit into from Sep 21, 2020

Conversation

schmittlauch
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [x]] Fits CONTRIBUTING.md.

@schmittlauch
Copy link
Member Author

@GrahamcOfBorg build cawbird

@schmittlauch
Copy link
Member Author

If this isn't merged before the 20.09 branch-off, it also needs a backport to release-20.09.

@tomberek
Copy link
Contributor

tomberek commented Sep 6, 2020

Result of nixpkgs-review pr 97230 1

1 package built:
- cawbird

@tomberek
Copy link
Contributor

tomberek commented Sep 6, 2020

builds and runs on NixOS. did not test functionality. Version bump and additional dependency.

@schmittlauch schmittlauch changed the title cawbird: 1.1.0 -> 1.2.0-2 cawbird: 1.1.0 -> 1.2.1 Sep 20, 2020
@schmittlauch
Copy link
Member Author

schmittlauch commented Sep 20, 2020

rebased on latest master and bumped to bugfix release 1.2.1 instead of 1.2.0 (changes see https://github.com/IBBoard/cawbird/releases/tag/v1.2.1)

@schmittlauch
Copy link
Member Author

@GrahamcOfBorg build cawbird

@schmittlauch schmittlauch mentioned this pull request Sep 20, 2020
10 tasks
@schmittlauch
Copy link
Member Author

schmittlauch commented Sep 20, 2020

backport: #98326

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/304

@doronbehar doronbehar merged commit a95bf52 into NixOS:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants