Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liferea: 1.12.6 → 1.12.9 #97189

Merged
merged 1 commit into from Sep 7, 2020
Merged

liferea: 1.12.6 → 1.12.9 #97189

merged 1 commit into from Sep 7, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 5, 2020

Motivation for this change

Bug fixes: https://github.com/lwindolf/liferea/blob/v1.12.9/ChangeLog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl vbgl added this to the 20.09 milestone Sep 5, 2020
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally.

@vbgl vbgl merged commit d7fa5b6 into NixOS:master Sep 7, 2020
@vbgl vbgl deleted the liferea-1.12.9 branch September 7, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants