Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxsmm: 1.15 -> 1.16.1, improve derivation #97227

Merged
merged 1 commit into from Sep 16, 2020
Merged

libxsmm: 1.15 -> 1.16.1, improve derivation #97227

merged 1 commit into from Sep 16, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 5, 2020

Motivation for this change

The following changes are made to the derivation besides the version
bump:

  • Move all buildInputs to nativeBuildInputs.
  • Switch from Python 2 to Python 3.
  • Build a dynamic library by default.
  • Use gfortran version corresponding to gcc version.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk changed the title libxsmm: 1.15 -> 1.16.1, improve derivations libxsmm: 1.15 -> 1.16.1, improve derivation Sep 5, 2020
@danieldk
libxsmm: 1.15 -> 1.16.1, improve derivation
9be28ee 
The following changes are made to the derivation besides the version
bump:

- Move all buildInputs to nativeBuildInputs.
- Switch from Python 2 to Python 3.
- Build a dynamic library by default.
- Use gfortran version corresponding to gcc version.
- Enable parallel building.
@chessai
Copy link
Member

chessai commented Sep 16, 2020

LGTM

@danieldk danieldk merged commit 6338098 into NixOS:master Sep 16, 2020
@danieldk danieldk deleted the libxsmm-1.16.1 branch September 16, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chessai chessai chessai approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @chessai