Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{enlightenment.efl,pythonPackages.pythonefl}: 1.24.3 -> 1.25.0 #98896

Merged
merged 2 commits into from Sep 28, 2020
Merged

{enlightenment.efl,pythonPackages.pythonefl}: 1.24.3 -> 1.25.0 #98896

merged 2 commits into from Sep 28, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Sep 26, 2020

Motivation for this change
  • Update to version 1.25.0
  • Explicitly enable Lua launcher binary support and language bindings, as they are now disabled by default
  • Remove a patch that has been integrated upstream
  • luaL_reg is no longer required (according to Fedora package)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
enlightenment.efl: 1.24.3 -> 1.25.0
3df1ed1 
- Update version
- Explicitly enable Lua launcher binary support and language bindings,
  as they are now disabled by default
- Remove a patch that has been integrated upstream
- luaL_reg is no longer required (according to Fedora package: https://src.fedoraproject.org/rpms/efl/blob/master/f/efl.spec)
@romildo
pythonPackages.pythonefl: 1.24.0 -> 1.25.0
9c132e3
jonringer
jonringer approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/98896
10 packages built:
enlightenment.econnman enlightenment.efl enlightenment.enlightenment enlightenment.ephoto enlightenment.evisum enlightenment.rage enlightenment.terminology python27Packages.pythonefl python37Packages.pythonefl python38Packages.pythonefl

@romildo romildo merged commit d2f65bf into NixOS:master Sep 28, 2020
@romildo romildo deleted the upd.efl branch September 28, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @jonringer