Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.blessed: 1.15.0 -> 1.17.10 #98886

Merged
merged 1 commit into from Oct 4, 2020
Merged

pythonPackages.blessed: 1.15.0 -> 1.17.10 #98886

merged 1 commit into from Oct 4, 2020

Conversation

austinbutler
Copy link
Member

@austinbutler austinbutler commented Sep 26, 2020 •
edited

Motivation for this change

Looking into fixing the inquirer Python package for ZHF and it depends on a new version of blessed. Also just to upgrade the package in general.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from eqyiel September 26, 2020 20:25
@austinbutler
Copy link
Member Author

@jonringer I'm waiting on this PR for fixing https://hydra.nixos.org/build/128023281 and I think possibly it got lost in the shuffle.

@austinbutler austinbutler mentioned this pull request Oct 3, 2020
Merged
10 tasks
@jonringer
Copy link
Contributor 

https://github.com/NixOS/nixpkgs/pull/98886
5 packages failed to build:
python37Packages.dask-xgboost python37Packages.myfitnesspal python37Packages.optuna python38Packages.dask-xgboost python38Packages.myfitnesspal

14 packages built:
awsebcli mailman-web python27Packages.blessed python37Packages.blessed python37Packages.datatable python37Packages.django-q python37Packages.hyperkitty python37Packages.mailman-web python37Packages.xgboost python38Packages.blessed python38Packages.datatable python38Packages.django-q python38Packages.hyperkitty python38Packages.xgboost

let me get #99575 in and retry

jonringer
jonringer approved these changes Oct 4, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/98886
3 packages failed to build:
python37Packages.myfitnesspal python37Packages.optuna python38Packages.myfitnesspal

16 packages built:
awsebcli mailman-web python27Packages.blessed python37Packages.blessed python37Packages.dask-xgboost python37Packages.datatable python37Packages.django-q python37Packages.hyperkitty python37Packages.mailman-web python37Packages.xgboost python38Packages.blessed python38Packages.dask-xgboost python38Packages.datatable python38Packages.django-q python38Packages.hyperkitty python38Packages.xgboost

@jonringer jonringer merged commit a231baa into NixOS:master Oct 4, 2020
@austinbutler austinbutler deleted the blessed-upgrade branch October 5, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@eqyiel eqyiel Awaiting requested review from eqyiel

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@austinbutler @jonringer