Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] pythonPackages.accupy: remove perfplot from checkInputs, fixing build #98893

Merged
merged 1 commit into from Sep 27, 2020
Merged

[20.09] pythonPackages.accupy: remove perfplot from checkInputs, fixing build #98893

merged 1 commit into from Sep 27, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 26, 2020

Motivation for this change

ZHF: #97479

Backport of #98860

Again, still broken on darwin for now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
pythonPackages.accupy: remove perfplot from checkInputs
9f7fe03 
they were only used for performance tests that aren't useful to us -
disabling these tests allows us to decouple from an unnecessary build
dependency.

convert to pytestCheckHook.

(cherry picked from commit 99175cf)
@ofborg ofborg bot requested a review from costrouc September 26, 2020 23:42
jonringer
jonringer approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98893 1

2 packages built:
  • python37Packages.accupy
  • python38Packages.accupy

@jonringer jonringer merged commit 2a904dc into NixOS:release-20.09 Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer