Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.tensorflow: 1.15.2 -> 1.15.4 #98883

Closed
wants to merge 1 commit into from
Closed

python37Packages.tensorflow: 1.15.2 -> 1.15.4 #98883

wants to merge 1 commit into from

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 26, 2020 •
edited

Motivation for this change

Changes:

https://github.com/tensorflow/tensorflow/releases/tag/v1.15.4

(Still building the CUDA version for verification.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk changed the title <!-- To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls Reviewing guidelines: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions --> python3Packages.tensorflow: 1.15.2 -> 1.15.4 Sep 26, 2020
@danieldk danieldk changed the title python3Packages.tensorflow: 1.15.2 -> 1.15.4 python37Packages.tensorflow: 1.15.2 -> 1.15.4 Sep 26, 2020
@danieldk danieldk closed this Sep 26, 2020
@jonringer
Copy link
Contributor

why did you close?

@danieldk
Copy link
Contributor Author

Noticed too late that there is another b0rked version bound. I will reopen this PR once I have fixed it (doing CPU test build now).

@jonringer
Copy link
Contributor

I really wish python packaging wasn't a hot mess

@danieldk
Copy link
Contributor Author

danieldk commented Sep 27, 2020 •
edited

I really wish python packaging wasn't a hot mess

Yeah, the most fun part is checking version constraints when the build itself is already done.

@danieldk
Copy link
Contributor Author

GitHub wants me to open a new PR, since there were changes: #98921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @jonringer