Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Poisson series implementation #2736

Merged
merged 9 commits into from
Sep 27, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Sep 27, 2020

  1. Add a private constructor that avoids sorting.
  2. Reduce a bit the number of evaluations of trigonometric functions.
  3. In the dot product, instead of using formal multiplication and formal integration, use evaluation followed by multiplication and Gauss integration.
  4. Add a parameter to the dot product to specify the number of points to use (mostly for tests, the default should work in real life).

#2400.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
# Conflicts:
#	numerics/poisson_series_body.hpp
…temporary measure until we have a smarter integrator.
@eggrobin eggrobin added the LGTM label Sep 27, 2020
@pleroy pleroy merged commit ddb36de into mockingbirdnest:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants