Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.alerta: add missing dependency #98894

Merged
merged 1 commit into from Sep 27, 2020
Merged

python3Packages.alerta: add missing dependency #98894

merged 1 commit into from Sep 27, 2020

Conversation

austinbutler
Copy link
Member

@austinbutler austinbutler commented Sep 26, 2020 •
edited

Motivation for this change

Following from #98881, this finally fixes the Alerta Hydra failure.

ZHF: #97479
https://hydra.nixos.org/build/127654289

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Sep 26, 2020

WFM macos 10.14, non-nixos linux x86_64

@ofborg build python37Packages.alerta python38Packages.alerta

@risicle risicle merged commit ad58fe1 into NixOS:master Sep 27, 2020
@austinbutler austinbutler mentioned this pull request Sep 27, 2020
Merged
10 tasks
@austinbutler austinbutler deleted the alerta-missing-dep branch May 24, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@austinbutler @risicle