zoom-us: 5.1 -> 5.2 #96867
zoom-us: 5.1 -> 5.2 #96867
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
|
The commit message should be just like the PR title, only with accurate versions near the |
|
Additionally, I noticed that the updateScript doesn't work anymore, as they probably changed something in their infrastructure. This works: diff --git i/pkgs/applications/networking/instant-messengers/zoom-us/update.sh w/pkgs/applications/networking/instant-messengers/zoom-us/update.sh
index 6214d4e2625..bda9c5ae0a0 100755
--- i/pkgs/applications/networking/instant-messengers/zoom-us/update.sh
+++ w/pkgs/applications/networking/instant-messengers/zoom-us/update.sh
@@ -1,17 +1,8 @@
#!/usr/bin/env nix-shell
-#!nix-shell -i bash -p curl pcre common-updater-scripts
+#!nix-shell -i bash -p curl pup common-updater-scripts
set -eu -o pipefail
-oldVersion=$(nix-instantiate --eval -E "with import ./. {}; lib.getVersion zoom-us" | tr -d '"')
-version="$(curl -sI https://zoom.us/client/latest/zoom_x86_64.tar.xz | grep -Fi 'Location:' | pcregrep -o1 '/(([0-9]\.?)+)/')"
+version="$(curl -Ls https://zoom.us/download\?os\=linux | pup '.linux-ver-text text{}' | cut -d' ' -f2)"
-if [ ! "${oldVersion}" = "${version}" ]; then
- update-source-version zoom-us "$version"
- nixpkgs="$(git rev-parse --show-toplevel)"
- default_nix="$nixpkgs/pkgs/applications/networking/instant-messengers/zoom-us/default.nix"
- git add "${default_nix}"
- git commit -m "zoom-us: ${oldVersion} -> ${version}"
-else
- echo "zoom-us is already up-to-date"
-fi
+update-source-version zoom-us "$version"2 things this does:
|
thanks to @doronbehar for changes to update script
|
Wow, that update script would have saved me a bunch of trouble yesterday, thanks @doronbehar! I updated the commit message as suggested, included your changes to the update script, then updated again (there seems to be yet another minor version update). The new new version builds and runs for me still on NixOS. |
|
@doronbehar Your other PR is ahead a few versions of this PR #97543 but it doesn't include the update script |
|
Right.. I forgot. @alevy could you give one more update here? I have commit permissions now 👼. |
|
Done. Thanks @mkg20001 & @doronbehar for triaging and congrats @doronbehar on commit permissions :) Zoom on NixOS is in good hands. |
Motivation for this change
New release of Zoom for Linux (August 17th) , just on time for the fall semester.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)