Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snooze: init at 0.4 #96698

Merged
merged 1 commit into from Oct 15, 2020
Merged

snooze: init at 0.4 #96698

merged 1 commit into from Oct 15, 2020

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Aug 30, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
$ nix-build . -A snooze
$ nix path-info -S ./result
/nix/store/sg3lv6j0bmbfdya48qbbgy80mw43dy6v-snooze-0.4    32991032

@KAction
Copy link
Contributor Author

KAction commented Oct 14, 2020

@ryantm Can you merge, please?

ryantm
ryantm requested changes Oct 15, 2020
View reviewed changes
pkgs/tools/system/snooze/default.nix Outdated Show resolved Hide resolved
@ryantm
Copy link
Member

ryantm commented Oct 15, 2020

Result of nixpkgs-review pr 96698 1

1 package built:
- snooze

@ryantm ryantm merged commit c4679aa into NixOS:master Oct 15, 2020
@KAction KAction deleted the snooze branch October 29, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KAction @ryantm @sikmir