Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron updates #96871

Merged
merged 6 commits into from Sep 9, 2020
Merged

Electron updates #96871

merged 6 commits into from Sep 9, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Aug 31, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member Author

prusnak commented Aug 31, 2020

@GrahamcOfBorg build electron_7 electron_8 electron_9 electron_10

@ofborg ofborg bot requested a review from danieldk September 1, 2020 15:40
@prusnak
Copy link
Member Author

prusnak commented Sep 9, 2020

Updated versions 8, 9 and 10 to the latest

@ofborg ofborg bot requested a review from danieldk September 9, 2020 08:45
@worldofpeace worldofpeace merged commit 341eeeb into NixOS:master Sep 9, 2020
@worldofpeace
Copy link
Contributor

@prusnak Thanks a lot ✨ I think, is it possible you could backport this to 20.09?

@prusnak prusnak deleted the electron branch September 9, 2020 15:23
@prusnak prusnak mentioned this pull request Sep 9, 2020
10 tasks
@prusnak
Copy link
Member Author

prusnak commented Sep 9, 2020

Backport to 20.09 here: #97552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants