Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-highlight: Skip building docs when cross-compiling #96762

Merged
merged 1 commit into from Jan 17, 2021
Merged

source-highlight: Skip building docs when cross-compiling #96762

merged 1 commit into from Jan 17, 2021

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Aug 31, 2020

Motivation for this change

source-highlight uses it's own binary to generate documentation.
During cross-compilation, that binary was built for the target
platform architecture, so it can't run on the build host.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka kampka added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Aug 31, 2020
@kampka
Copy link
Contributor Author

kampka commented Aug 31, 2020

@GrahamcOfBorg build sourceHighlight
@GrahamcOfBorg build pkgsCross.aarch64-multiplatfrom.sourceHighlight

@kampka
source-highlight: Skip building docs when cross-compiling
cbfc33a 
source-highlight uses it's own binary to generate documentation.
During cross-compilation, that binary was built for the target
platform architecture, so it can't run on the build host.
@symphorien
Copy link
Member

@GrahamcOfBorg build sourceHighlight
@GrahamcOfBorg build pkgsCross.aarch64-multiplatfrom.sourceHighlight

@symphorien symphorien merged commit 979e6e6 into NixOS:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kampka @symphorien