Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

robotframework: Add unit tests and optional dependencies #96873

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

robotframework: Add unit tests and optional dependencies #96873

wants to merge 1 commit into from

Conversation

WhittlesJr
Copy link
Contributor

Motivation for this change

The robot executable was failing to run my tests, because it needed a dependency called "tkinter." Simply adding it here fixed the issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WhittlesJr WhittlesJr changed the title Rf tkinter Robot Framework: Add tkinter dependency Aug 31, 2020
@WhittlesJr WhittlesJr force-pushed the rf-tkinter branch 2 times, most recently from fd92a4a to f739f59 Compare September 1, 2020 13:59
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/mktime-out-of-range-during-python-unit-tests/8848/1

@WhittlesJr WhittlesJr changed the title Robot Framework: Add tkinter dependency Robot Framework: Add unit tests and optional dependencies Sep 11, 2020
@WhittlesJr WhittlesJr changed the title Robot Framework: Add unit tests and optional dependencies robotframework: Add unit tests and optional dependencies Sep 11, 2020
@SuperSandro2000
Copy link
Member

Can you please fix the merge conflict?

@WhittlesJr
Copy link
Contributor Author

@jonringer , @SuperSandro2000

So sorry for the delay. Does this look good?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 96873 run on x86_64-linux 1

30 packages failed to build and are new build failures:
  • python37Packages.robomachine
  • python37Packages.robotframework
  • python37Packages.robotframework-databaselibrary
  • python37Packages.robotframework-requests
  • python37Packages.robotframework-selenium2library
  • python37Packages.robotframework-seleniumlibrary
  • python37Packages.robotframework-sshlibrary
  • python37Packages.robotframework-tools
  • python37Packages.robotstatuschecker
  • python37Packages.robotsuite
  • python38Packages.robomachine
  • python38Packages.robotframework
  • python38Packages.robotframework-databaselibrary
  • python38Packages.robotframework-requests
  • python38Packages.robotframework-selenium2library
  • python38Packages.robotframework-seleniumlibrary
  • python38Packages.robotframework-sshlibrary
  • python38Packages.robotframework-tools
  • python38Packages.robotstatuschecker
  • python38Packages.robotsuite
  • python39Packages.robomachine
  • python39Packages.robotframework
  • python39Packages.robotframework-databaselibrary
  • python39Packages.robotframework-requests
  • python39Packages.robotframework-selenium2library
  • python39Packages.robotframework-seleniumlibrary
  • python39Packages.robotframework-sshlibrary
  • python39Packages.robotframework-tools
  • python39Packages.robotstatuschecker
  • python39Packages.robotsuite

I think it fails due to modeled failing which is fixed in #108084

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 96873 run on x86_64-darwin 1

30 packages failed to build:
  • python37Packages.robomachine
  • python37Packages.robotframework
  • python37Packages.robotframework-databaselibrary
  • python37Packages.robotframework-requests
  • python37Packages.robotframework-selenium2library
  • python37Packages.robotframework-seleniumlibrary
  • python37Packages.robotframework-sshlibrary
  • python37Packages.robotframework-tools
  • python37Packages.robotstatuschecker
  • python37Packages.robotsuite
  • python38Packages.robomachine
  • python38Packages.robotframework
  • python38Packages.robotframework-databaselibrary
  • python38Packages.robotframework-requests
  • python38Packages.robotframework-selenium2library
  • python38Packages.robotframework-seleniumlibrary
  • python38Packages.robotframework-sshlibrary
  • python38Packages.robotframework-tools
  • python38Packages.robotstatuschecker
  • python38Packages.robotsuite
  • python39Packages.robomachine
  • python39Packages.robotframework
  • python39Packages.robotframework-databaselibrary
  • python39Packages.robotframework-requests
  • python39Packages.robotframework-selenium2library
  • python39Packages.robotframework-seleniumlibrary
  • python39Packages.robotframework-sshlibrary
  • python39Packages.robotframework-tools
  • python39Packages.robotstatuschecker
  • python39Packages.robotsuite

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@bjornfor
Copy link
Contributor

Fix commit message?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@bjornfor
Copy link
Contributor

Oh, and rebase on master to fix conflicts (related: 738e8eb).

@WhittlesJr
Copy link
Contributor Author

@bjornfor , How's that?

bjornfor
bjornfor reviewed Jul 19, 2021
View reviewed changes
pkgs/development/python-modules/robotframework/default.nix
{ lib, fetchFromGitHub, buildPythonPackage, jsonschema }:
{ lib, fetchFromGitHub, buildPythonPackage,
tkinter, xmlschema, docutils, pygments, pyyaml, enum34, enum-compat, pillow, lxml, jsonschema,
python }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'python' is unused, can be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tkinter is used for the Dialog library (or something), what are the other deps for? (Perhaps say something about that in the commit message.)

SuperSandro2000
SuperSandro2000 reviewed Jul 20, 2021
View reviewed changes
pkgs/development/python-modules/robotframework/default.nix
Comment on lines +1 to +3
{ lib, fetchFromGitHub, buildPythonPackage,
tkinter, xmlschema, docutils, pygments, pyyaml, enum34, enum-compat, pillow, lxml, jsonschema,
python }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ lib, fetchFromGitHub, buildPythonPackage,
tkinter, xmlschema, docutils, pygments, pyyaml, enum34, enum-compat, pillow, lxml, jsonschema,
python }:
{ lib, fetchFromGitHub, buildPythonPackage,
, tkinter, xmlschema, docutils, pygments, pyyaml, enum34, enum-compat, pillow, lxml, jsonschema,
, python }:

SuperSandro2000
SuperSandro2000 reviewed Jul 20, 2021
View reviewed changes
pkgs/development/python-modules/robotframework/default.nix
@@ -11,6 +13,8 @@ buildPythonPackage rec {
sha256 = "1wqz7szbq2g3kkm7frwik4jb5m7517306sz8nxx8hxaw4n6y1i5d";
};

propagatedBuildInputs = [ tkinter xmlschema docutils pygments pyyaml enum34 enum-compat pillow lxml ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please gate enum43 like lib.optional (pythonOlder "3.4") enum34.

@stale
Copy link

stale bot commented Apr 19, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 19, 2022
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank marked this pull request as draft March 25, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@WhittlesJr @nixos-discourse @SuperSandro2000 @bjornfor @jonringer @wegank