Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace language:nix #234

Merged
merged 2 commits into from Sep 14, 2020
Merged

replace language:nix #234

merged 2 commits into from Sep 14, 2020

Conversation

abathur
Copy link
Member

@abathur abathur commented Aug 31, 2020

Draft PR to make CI run, per request from @Mic92 :)

@Mic92
Copy link
Member

Mic92 commented Sep 1, 2020

The background here is that we plan to move travis ci support for nix in a separate repository.
Right now it is supported by travis upstream however this integration is not well maintained and
changes take too long to get in. Having versioned nix installer allows smoother upgrades similar to how the install-nix github action works. See also https://discourse.nixos.org/t/fate-of-travis-ci-nix-language-support/7907/12

@Mic92
Copy link
Member

Mic92 commented Sep 3, 2020

Any reason to still mark it as a draft?

@abathur abathur marked this pull request as ready for review September 3, 2020 12:44
@abathur
Copy link
Member Author

abathur commented Sep 3, 2020

@Mic92 No functional reason; I just moved this whole effort to the backburner for a few days to try to get resholved into nixpkgs before branch-off, so I haven't done any more here aside from address your comments. (I've got tabs with the rest of the nix-community repos that use travis-ci, for example, to PR when I have a little more time...)

@Mic92
Copy link
Member

Mic92 commented Sep 13, 2020

cc @domenkozar for review. We are also using this in NUR for quite some time.

@domenkozar domenkozar merged commit 67005a9 into NixOS:master Sep 14, 2020
@abathur abathur deleted the patch-1 branch March 4, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants