Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert “nixos/test-driver: use pythons logging module” (#96254) #96703

Merged
merged 2 commits into from Aug 30, 2020
Merged

Revert “nixos/test-driver: use pythons logging module” (#96254) #96703

merged 2 commits into from Aug 30, 2020

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Aug 30, 2020

Motivation for this change

Fixes several broken tests including a channel blocker (#96699) by reverting #96254. Also revert #96152 because of conflicts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andersk
Revert "Merge pull request NixOS#96152 from JJJollyjim/colour-test-ma…
a0a421b 
…chines-staging"

This reverts commit 1bff6fe, reversing
changes made to 2995fa4.

There’s presumably nothing wrong with this PR, except that it
conflicts with reverting NixOS#96254 which broke several tests (NixOS#96699).

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk
Revert "Merge pull request NixOS#96254 from Mic92/logging"
59b6664 
This reverts commit 4fc7085, reversing
changes made to 0e54f3a.

Fixes NixOS#96699.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk requested a review from tfc as a code owner August 30, 2020 22:50
@andersk andersk mentioned this pull request Aug 30, 2020
Closed
@andersk andersk added 0.kind: regression Something that worked before working no longer 1.severity: channel blocker Blocks a channel 11.by: nixpkgs-member 6.topic: testing Tooling for automated testing of packages and modules labels Aug 30, 2020
@worldofpeace worldofpeace merged commit 5c67236 into NixOS:master Aug 30, 2020
@worldofpeace
Copy link
Contributor

Thanks. Hopefully @Mic92 can re-pr reverting this and fixing those test cases etc.

This was referenced Aug 30, 2020
Merged
Merged
Merged
@andersk andersk deleted the revert-test-logging branch December 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc Awaiting requested review from tfc tfc is a code owner

@Mic92 Mic92 Awaiting requested review from Mic92

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 1.severity: channel blocker Blocks a channel 6.topic: testing Tooling for automated testing of packages and modules 11.by: nixpkgs-member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andersk @worldofpeace