Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goreplay: init at 1.1.0 #96728

Merged
merged 1 commit into from Sep 3, 2020
Merged

goreplay: init at 1.1.0 #96728

merged 1 commit into from Sep 3, 2020

Conversation

lovek323
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovek323 lovek323 force-pushed the goreplay branch 2 times, most recently from 80f34be to ef71a81 Compare September 1, 2020 00:14
@davidak
Copy link
Member

davidak commented Sep 3, 2020

Please follow CONTRIBUTING.md! commit message, description

@lovek323
Copy link
Member Author

lovek323 commented Sep 3, 2020

Please follow CONTRIBUTING.md! commit message, description

Thanks, will update.

@lovek323 lovek323 changed the title goreplay: add v1.1.0 goreplay: init at 1.1.0 Sep 3, 2020
@zowoq zowoq merged commit 2eacb60 into NixOS:master Sep 3, 2020
@lovek323 lovek323 deleted the goreplay branch September 3, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovek323 @davidak @zowoq