Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/cri-o: unset hooks dir to avoid dir creation on startup #96837

Merged
merged 1 commit into from Sep 1, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 31, 2020

Motivation for this change

The hooks directory is created on startup of CRI-O and NixOS does not provide any hooks per default. I think it is save to disable it.

cc @NixOS/podman

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor

zowoq commented Aug 31, 2020

Nit: for nixos modules/tests the commit message should be prefixed, e.g. nixos/cri-o: ...

Otherwise lgtm.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

Nit: for nixos modules/tests the commit message should be prefixed, e.g. nixos/cri-o: ...

Otherwise lgtm.

Fixed. 👍

@saschagrunert saschagrunert changed the title cri-o: unset hooks dir to avoid dir creation on startup nixos/cri-o: unset hooks dir to avoid dir creation on startup Sep 1, 2020
@zowoq zowoq merged commit 46a0aa4 into NixOS:master Sep 1, 2020
@saschagrunert saschagrunert deleted the crio-hooks-dir branch September 1, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants