Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests: Disable networking.networkd.macvlan #96712

Merged
merged 1 commit into from Aug 31, 2020
Merged

nixosTests: Disable networking.networkd.macvlan #96712

merged 1 commit into from Aug 31, 2020

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Aug 31, 2020

Motivation for this change

This test is failing nondeterministically. Fixes #96709.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andersk
nixosTests: Disable networking.networkd.macvlan
a05b904 
This test is failing nondeterministically.  Fixes NixOS#96709.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk added 0.kind: regression Something that worked before working no longer 1.severity: channel blocker Blocks a channel 6.topic: testing Tooling for automated testing of packages and modules 11.by: nixpkgs-member labels Aug 31, 2020
@worldofpeace worldofpeace merged commit bd5a11f into NixOS:master Aug 31, 2020
@worldofpeace
Copy link
Contributor

Thanks again @andersk

@andersk andersk deleted the disable-macvlan branch December 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 1.severity: channel blocker Blocks a channel 6.topic: nixos 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: nixpkgs-member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixosTests.networking.networkd.macvlan fails nondeterministically
2 participants
@andersk @worldofpeace