Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-template: init at 0.1.0 #96713

Merged
merged 1 commit into from Aug 31, 2020
Merged

nix-template: init at 0.1.0 #96713

merged 1 commit into from Aug 31, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 31, 2020 •
edited

Motivation for this change

I've been cooking up a small CLI program to help with having to generate largely boilerplate nix expressions

Felt like it was "good" enough for a beta "0.1.0" release

Also using it as an excuse to learn Rust.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-template-at-v0-1-0/8820/1

danieldk
danieldk approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96713 1

1 package built:
  • nix-template

Binary works!

@danieldk danieldk merged commit 54e64ac into NixOS:master Aug 31, 2020
@jonringer jonringer deleted the add-nix-template branch August 31, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @nixos-discourse @danieldk