Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgnomeui: Update patch URL. #96714

Merged
merged 1 commit into from Sep 1, 2020
Merged

libgnomeui: Update patch URL. #96714

merged 1 commit into from Sep 1, 2020

Conversation

kevincox
Copy link
Contributor

@kevincox kevincox commented Aug 31, 2020 •
edited

The GitHub repo has been removed but the commit is available on the GNOME GitLab.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kevincox
libgnomeui: Update patch URL.
1990bca 
The GitHub repo has been removed but the commit is available on the GNOME GitLab.
@kevincox kevincox self-assigned this Aug 31, 2020
danieldk
danieldk approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@danieldk danieldk merged commit 5fa5d6d into master Sep 1, 2020
@danieldk danieldk deleted the kevincox-libgnomeui-patch branch September 1, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@OmnipotentEntity OmnipotentEntity Awaiting requested review from OmnipotentEntity

Assignees

@kevincox kevincox

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevincox @danieldk