Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numworks: init udev rules and module #96831

Merged
merged 1 commit into from Sep 2, 2020
Merged

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

Just bought a numworks calculator and needed to upgrade the firmware (will also hack a bit with it as all the software is opensource).

Things done

Packaged the linux udev rule for numworks calculators and created the corresponding module.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added some requested changes.

pkgs/os-specific/linux/numworks-udev-rules/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/numworks-udev-rules/default.nix Outdated Show resolved Hide resolved
@danieldk
Copy link
Contributor

danieldk commented Sep 2, 2020

50-numworks-calculator.rules is missing, maybe you could also change the commit message to:

numworks-udev-rules: init udev rules and module

(Since the first part should be the attribute name.)

@SCOTT-HAMILTON
Copy link
Contributor Author

Fixed.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96831 1

1 package built:
  • numworks-udev-rules

@danieldk danieldk merged commit f145223 into NixOS:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants