Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xtreme-Download-Manager: init at 7.2.11 #96861

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Xtreme-Download-Manager: init at 7.2.11 #96861

wants to merge 1 commit into from

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

#96557

Things done

Packaged xdman at release 7.2.11

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Aug 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also not a big fan of many thousand line lock files :(

pkgs/applications/networking/xtreme-download-manager/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/xtreme-download-manager/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/xtreme-download-manager/default.nix Show resolved Hide resolved
@jonringer
Copy link
Contributor

after https://gist.github.com/GrahamcOfBorg/afffda3c1a919e8156d46c906d824b5f is resolved, I still think you will have issues with import-from-derivation (IFD)

@SCOTT-HAMILTON SCOTT-HAMILTON force-pushed the xtreme-download-manager branch 3 times, most recently from 0f324ec to db00884 Compare September 1, 2020 10:11
OPNA2608
OPNA2608 requested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from these comments, I'm p sure the whole mvn2nix = import … thing won't fly in Nixpkgs? Though I don't know what's the best way to solve this as I have no insight at all into the Java side of Nixpkgs.

pkgs/applications/networking/xtreme-download-manager/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/xtreme-download-manager/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/xtreme-download-manager/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/xtreme-download-manager/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/xtreme-download-manager/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/xtreme-download-manager/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

jonringer commented Sep 1, 2020 •
edited

Nixpkgs isn't allowed to do import-from-derivation

cannot import '/nix/store/pa1555ank7g9axm8sp1frxnwg0xgalkk-source', since path '/nix/store/rddska8812a53ryzll92si5iks019q9a-source.drv' is not valid, at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/applications/networking/xtreme-download-manager/default.nix:10:13

@SCOTT-HAMILTON SCOTT-HAMILTON mentioned this pull request Sep 2, 2020
Closed
3 tasks
@SCOTT-HAMILTON
Copy link
Contributor Author

Moved the import to top-level/all-packages.nix. Is that fine?

@OPNA2608
Copy link
Contributor

OPNA2608 commented Sep 2, 2020

I think it's prolly best to not merge any uses of this mvn2nix tool into nixpkgs yet. The developer intends to showcase and open an RFC about it soon, see fzakaria/mvn2nix#4 (comment).

My plan is to try and get this in a polished state before NixCon and submit a RFC (Request For Content) to talk about it.

If it ends up being merged, that would automatically solve your import-from-derivation problem.

@SCOTT-HAMILTON
Copy link
Contributor Author

Fine, I'll wait for mvn2nix to be in nixpkgs.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft January 18, 2021 12:54
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@OPNA2608 OPNA2608 OPNA2608 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2.status: merge conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SCOTT-HAMILTON @jonringer @OPNA2608 @wegank