Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jbig2dec: Move autoreconfHook from buildInputs to nativeBuildInputs #96764

Merged
merged 1 commit into from Aug 31, 2020
Merged

jbig2dec: Move autoreconfHook from buildInputs to nativeBuildInputs #96764

merged 1 commit into from Aug 31, 2020

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Aug 31, 2020

Fixes cross-compilation issues with autoreconf not being available on the build host.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented Aug 31, 2020

@GrahamcOfBorg build jbig2dec
@GrahamcOfBorg build pkgsCross.aarch-multiplatform.jbig2dec

@kampka kampka requested review from prusnak and mmilata August 31, 2020 12:56
@kampka kampka added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Aug 31, 2020
@prusnak prusnak removed their request for review August 31, 2020 13:35
@FRidh FRidh merged commit d489c64 into NixOS:staging Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata Awaiting requested review from mmilata

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kampka @FRidh