noto-fonts: use poetry2nix for python build dependencies #96706
Conversation
The python dependencies are only used during the build of the font artifacts, so instead of having to manually package the transitive dependency graph for every single update, let’s just use a poetry lock file that can be bumped semi-automatically.
|
Where does this dependency specification come from? Not from https://github.com/googlefonts/noto-fonts. I find it absurd to use |
It is just the requirements.txt converted to a trivial poetry package toml file. (I used
I find it absurd that @sternenseemann had to spend hours bumping python dependencies for #96315 (review) This PR took me literally 10 minutes to write, everything is automated by poetry2nix. |
|
Well, the deed is done already, so not much point in reverting all the work. Bumping these mostly trivial packages won't be too much effort presumably. Also with |
I wonder what the story with test-suites in poetry2nix is @adisbladis. They are probably disabled by default because python packages like to do network I/O in their tests? |
Poetry only puts run-time dependencies in |
|
I don’t think tests for library dependencies are particularly relevant to the build tool. We should move towards a poetry-based approach for python-built binaries somewhat soon imho, since the maintenance effort for pythonPackages is immense. But I don’t have a big horse in the game. |
The python dependencies are only used during the build of the font
artifacts, so instead of having to manually package the transitive
dependency graph for every single update, let’s just use a poetry lock
file that can be bumped semi-automatically.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)