Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows/pending-set.yml: failed -> pending #96707

Merged
merged 1 commit into from Jan 30, 2021
Merged

.github/workflows/pending-set.yml: failed -> pending #96707

merged 1 commit into from Jan 30, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 30, 2020 •
edited

Blocked by NixOS/ofborg#527, it needs to be merged and deployed first.

Closes #96695

@zowoq zowoq added 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 9.needs: upstream fix labels Aug 30, 2020
endgame
endgame reviewed Aug 30, 2020
View reviewed changes
Copy link
Contributor

@endgame endgame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing task is pretty jarring when you first see it, but do pending tasks block merge? I think it's a great change if so but I don't have the commit bit.

@zowoq
Copy link
Contributor Author

zowoq commented Aug 30, 2020 •
edited

do pending tasks block merge

No, but the reason it is set to failed is:

#96056 (comment)
currently ofborg only sends check_suite at the end of eval so a PR that fails early will stay as pending

@worldofpeace
Copy link
Contributor

Is this something we can fix now that @grahamc is back?

@worldofpeace worldofpeace mentioned this pull request Oct 11, 2020
Closed
@zowoq
Copy link
Contributor Author

zowoq commented Dec 6, 2020

I'll reopen if NixOS/ofborg#527 progresses.

@zowoq zowoq closed this Dec 6, 2020
@zowoq zowoq reopened this Jan 29, 2021
@zowoq zowoq mentioned this pull request Jan 30, 2021
Merged
cole-h
cole-h approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be redeploying borg when I'm available in about 2-3 hours. After that succeeds, I'll merge this. Thanks!

@cole-h cole-h marked this pull request as ready for review January 30, 2021 03:40
@cole-h cole-h requested a review from Mic92 as a code owner January 30, 2021 03:40
@cole-h cole-h merged commit ac98f99 into NixOS:master Jan 30, 2021
@cole-h cole-h removed 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 9.needs: upstream fix labels Jan 30, 2021
@zowoq zowoq deleted the ofborg-pending branch January 30, 2021 06:24
@cole-h
Copy link
Member

cole-h commented Feb 10, 2021

"Backported" to release-20.09 in 6fbc72a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endgame endgame endgame left review comments

@cole-h cole-h cole-h approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wait for ofborg check sets a failed status when pending
4 participants
@zowoq @worldofpeace @cole-h @endgame