Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] Backport telegram-desktop to fix CVE-2020-17448 #96843

Merged
merged 10 commits into from Sep 25, 2020
Merged

[20.03] Backport telegram-desktop to fix CVE-2020-17448 #96843

merged 10 commits into from Sep 25, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Aug 31, 2020

Motivation for this change

Warning: I only verified that this builds, I didn't test if everything still works.

Merging this PR would fix #96823. But for what it's worth Debian isn't fixing this or previous CVEs for Buster:
https://security-tracker.debian.org/tracker/source-package/telegram-desktop
Details are here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

primeos and others added 10 commits August 31, 2020 16:22
@primeos
tdesktop: 2.1.0 -> 2.1.1
b727609 
Regarding microsoft_gsl: The CMake scripts from Telegram-Desktop did not
find it anymore (I didn't investigate this) and Arch already made this
change during the last update. It's probably best to do the same here
especially since Telegram-Desktop is currently based on GSL 3.0.1 while
our version is still at 2.1.0.

(cherry picked from commit e9e2f81)
@primeos
tdesktop: 2.1.1 -> 2.1.2
e7b56c5 
(cherry picked from commit 69dc7e6)
@primeos
tdesktop: 2.1.2 -> 2.1.4
1b4c1c9 
(cherry picked from commit 22fef8e)
@primeos
tdesktop: 2.1.4 -> 2.1.6
49f36c1 
(cherry picked from commit 6e5b1a7)
@primeos
tdesktop: 2.1.6 -> 2.1.7
a7447cb 
(cherry picked from commit 6d923b3)
@primeos
tdesktop: 2.1.7 -> 2.1.10
4b34051 
(cherry picked from commit 7ef22b9)
@primeos
tdesktop: 2.1.10 -> 2.1.11
50236f4 
(cherry picked from commit a1aecff)
@primeos
tdesktop: 2.1.11 -> 2.1.12
ddf54a1 
(cherry picked from commit b713e97)
@primeos
tdesktop: 2.1.12 -> 2.1.13
9b2648a 
(cherry picked from commit 10b11fe)
@oxalica @primeos
tdesktop: 2.1.13 -> 2.2.0 (NixOS#93901)
c3219cd 
(cherry picked from commit 2bd78b2)
@primeos primeos added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. labels Aug 31, 2020
@primeos primeos linked an issue Aug 31, 2020 that may be closed by this pull request
Vulnerability roundup 92: telegram-desktop-2.1.0: 1 advisory [7.8] #96823
Closed
1 task
@ofborg ofborg bot requested a review from abbradar August 31, 2020 16:39
@andir andir merged commit fe9a045 into NixOS:release-20.03 Sep 25, 2020
@primeos primeos mentioned this pull request Oct 1, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 92: telegram-desktop-2.1.0: 1 advisory [7.8]
3 participants
@primeos @andir @oxalica