buildGoPackage: check/delete vendor #96735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zowoq
commented
Sep 1, 2020
| }; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig ]; | ||
| # livepeer_cli has a vendoring problem |
There was a problem hiding this comment.
Out of ~390 buildGoPackages this seems to be the only one that breaks and it's non-trivial to fix.
(The previous version also has issues.)
I'll come back to it after this PR is merged.
kalbasit
approved these changes
Sep 2, 2020
|
I'll merge after the branch off. |
|
Rechecked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen several existing and newly submitted packages using an unnecessary
goDepswithbuildGoPackage, hopefully this would point people in the right direction.Copied
deleteVendorfrombuildGoModuleto cover cases when we don't want to use the vendor folder.Would need to rebuild/fix packages and update docs before merging.Done.cc @NixOS/golang