Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup: add zlib as runtime dependency #96855

Merged
merged 1 commit into from Sep 2, 2020
Merged

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

rustup needs zlib as runtime dependency.

Fixes #92946.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

1 similar comment
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@Gerschtli
Copy link
Contributor Author

According to the Readme OfBorg runs eval by default and I think you need to mention @ ofborg instead @ GrahamcOfBorg.

@jonringer
Copy link
Contributor

@Gerschtli it does, I just accidentally killed it for a few minutes on master, and was trying to fix PRs that were checked out during that time

Copy link
Contributor

@steveej steveej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that adding zlib to a nix-shell environment is required for rust 1.46 to work. It'd be nice to not require that workaround.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96855 1

1 package built:
  • rustup

@jonringer jonringer merged commit b2679e8 into NixOS:master Sep 2, 2020
@Gerschtli Gerschtli deleted the fix/rustup branch September 2, 2020 17:59
@paveloom paveloom mentioned this pull request Aug 26, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly rustc needs libz.so.1 to run
3 participants