Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gatsby-cli: init at 2.12.89 #96857

Closed
wants to merge 1 commit into from
Closed

gatsby-cli: init at 2.12.89 #96857

wants to merge 1 commit into from

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

Inits gatsby-cli at 2.12.89

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mkg20001
Copy link
Member

@Gerschtli is this still being worked on? currently it has merge conflicts that need to be resolved before it can be merged.

@Gerschtli
Copy link
Contributor Author

I will resolve it soon.

@Gerschtli
Copy link
Contributor Author

gatsby-cli is already available in nixpkgs-unstable: https://search.nixos.org/packages?channel=unstable&show=nodePackages.gatsby-cli&from=0&size=50&sort=relevance&query=gatsby

@Gerschtli Gerschtli closed this Apr 29, 2021
@Gerschtli Gerschtli deleted the add/gatsby-cli branch April 29, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gerschtli @mkg20001 @ryantm