Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mob: init at v0.0.25 #96854

Merged
merged 1 commit into from Dec 14, 2020
Merged

mob: init at v0.0.25 #96854

merged 1 commit into from Dec 14, 2020

Conversation

ericdallo
Copy link
Member

Motivation for this change

Add mob (https://github.com/remotemobprogramming/mob)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

1 similar comment
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

dali99
dali99 suggested changes Sep 4, 2020
View reviewed changes
pkgs/applications/misc/mob/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/mob/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/mob/default.nix Outdated Show resolved Hide resolved
@ericdallo
Copy link
Member Author

Done, thanks @dali99

@doronbehar
Copy link
Contributor

Please fix merge conflicts.

@doronbehar
Copy link
Contributor

@ofborg eval

@doronbehar
Copy link
Contributor

@GrahamcOfBorg eval

@ericdallo
Copy link
Member Author

Done @doronbehar

@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 96854 run on x86_64-linux 1

1 package built:
  • mob

@doronbehar doronbehar merged commit 0fafd8e into NixOS:master Dec 14, 2020
@ericdallo ericdallo deleted the mob-init branch December 14, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@dali99 dali99 dali99 approved these changes

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ericdallo @jonringer @doronbehar @thiagokokada @dali99