Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.howdoi: 2.0.3 -> 2.0.4, fix build, init pythonPackages.keep @ 2.9 #96839

Merged
merged 2 commits into from Aug 31, 2020
Merged

pythonPackages.howdoi: 2.0.3 -> 2.0.4, fix build, init pythonPackages.keep @ 2.9 #96839

merged 2 commits into from Aug 31, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Aug 31, 2020

Motivation for this change

Multiple things were stopping howdoi building following its recent bump. It had a new missing dependency keep, and its tests were broken.

So I've added keep, and tweaked some overly-strict requirements, but eventually had to disable howdoi's tests as it looks like the author has not included the useful page_cache directory in the release tarball. The contents of this directory allow the tests to run without external network access. And the github repo isn't clearly tagged with release versions, so I didn't want to go that route. I did turn on pythonImportsCheck though, which is better than nothing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc August 31, 2020 15:51
@jonringer
Copy link
Contributor

sorry, I sorted python-packages, can you rebase? :)

@risicle
pythonPackages.keep: init at 2.9
c3c25d8
@risicle
pythonPackages.howdoi: 2.0.3 -> 2.0.4, fix build
ac68b87 
had to disable the tests (hopefully temporarily) because of missing
page_cache directory in release tarball.

removed no-longer-needed requests-cache dependency
@risicle
Copy link
Contributor Author

risicle commented Aug 31, 2020

You total lunatic. Done.

jonringer
jonringer approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96839 1

4 packages built:
  • python37Packages.howdoi
  • python37Packages.keep
  • python38Packages.howdoi
  • python38Packages.keep

@jonringer jonringer merged commit f2e3b79 into NixOS:master Aug 31, 2020
@risicle risicle mentioned this pull request Aug 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer