Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vivaldi: 3.1.1929.45-1 -> 3.2.1967.47-1 #96842

Closed
wants to merge 1 commit into from
Closed

vivaldi: 3.1.1929.45-1 -> 3.2.1967.47-1 #96842

wants to merge 1 commit into from

Conversation

badmutex
Copy link
Contributor

Motivation for this change

Update to most recent vivaldi

Things done

ran ./update.sh vivaldi

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from NeQuissimus and otwieracz August 31, 2020 16:23
@badmutex
Copy link
Contributor Author

badmutex commented Sep 2, 2020

@otwieracz @NeQuissimus ping ☝️

@tomberek
Copy link
Contributor

tomberek commented Sep 6, 2020

Result of nixpkgs-review pr 96842 1

1 package built:
- vivaldi

@tomberek
Copy link
Contributor

tomberek commented Sep 6, 2020

builds runs and functions as expected on NixOS.

@badmutex
Copy link
Contributor Author

badmutex commented Sep 6, 2020

@jonringer mind taking a look? wanting this in for the 20.09 branch off.
(been running it as my main browser for a week now without issue)

@badmutex
Copy link
Contributor Author

badmutex commented Sep 9, 2020

superseded by #97551

@badmutex badmutex closed this Sep 9, 2020
@badmutex badmutex deleted the badi/update-vivaldi branch September 9, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@otwieracz otwieracz Awaiting requested review from otwieracz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@badmutex @tomberek