Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvim: drop it #96768

Merged
merged 1 commit into from Aug 31, 2020
Merged

qvim: drop it #96768

merged 1 commit into from Aug 31, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Upstream has moved development to neovim instead where this frontend is
now based on Qt5.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -23481,12 +23481,6 @@ in
inherit (xorg) libxcb;
};

qvim = lowPrio (callPackage ../applications/editors/vim/qvim.nix {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth adding an entry to aliases.nix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - done.

Upstream has moved development to neovim instead where this frontend is
now based on Qt5.
@danieldk danieldk merged commit c9e9013 into NixOS:master Aug 31, 2020
@peterhoeg peterhoeg deleted the d/qvim branch September 7, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants