Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-packages.nix: sort #96850

Merged
merged 1 commit into from Aug 31, 2020
Merged

python-packages.nix: sort #96850

merged 1 commit into from Aug 31, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 31, 2020 •
edited

Motivation for this change

really didn't like that the package set was so disorganized.

Also gets rid of the "why should I sort new packages in an unsorted list " excuse :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner August 31, 2020 17:11
@FRidh
Copy link
Member

FRidh commented Aug 31, 2020 •
edited 

anonymous function at /home/freddy/Code/libraries/nixpkgs/pkgs/applications/video/jellyfin-mpv-shim/default.nix:1:1 called without required argument 'tkinter'

Checked with

#!/bin/sh

echo "Checking evaluation before committing";
exec nix-env -f . -qaP --meta --json --drv-path --show-trace >/dev/null

tkinter disappeared

@jonringer jonringer marked this pull request as draft August 31, 2020 17:17
@jonringer
Copy link
Contributor Author

looks like eval is fixed, and I'm able to build most packages

@jonringer jonringer marked this pull request as ready for review August 31, 2020 17:23
@FRidh
Copy link
Member

FRidh commented Aug 31, 2020 

Nothing changed
https://github.com/NixOS/nixpkgs/pull/96850

@FRidh FRidh merged commit 6b23dc8 into NixOS:master Aug 31, 2020
@jonringer jonringer deleted the sort-python-packages branch August 31, 2020 17:26
@FRidh
Copy link
Member

FRidh commented Aug 31, 2020

Thanks. Now we can rule with a iron fist again! 😛

@jonringer
Copy link
Contributor Author

Had to run the ofborg eval locally to find other other missing packages. I guess nix-env --json doesn't deeply evaluate anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh