Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel_0: fix build on darwin #99967

Merged
merged 1 commit into from Oct 8, 2020
Merged

bazel_0: fix build on darwin #99967

merged 1 commit into from Oct 8, 2020

Conversation

tricktron
Copy link
Member

Motivation for this change

ZHF: #97479
cc: @NixOS/nixos-release-managers

Fixes error: thread-local storage is not supported for the current target by
upgrading clang_7 -> to clang_8 which supports thread-local storage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bazel_0: fix build on darwin
169998c 
Fixes `error: thread-local storage is not supported for the current target` by
upgrading clang_7 -> to clang_8 which supports thread-local storage.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 7, 2020
@ofborg ofborg bot requested a review from mboes October 7, 2020 17:54
@Profpatsch
Copy link
Member

Look good, same fixes as in #100012

@Profpatsch Profpatsch merged commit fd2c495 into NixOS:master Oct 8, 2020
@tricktron tricktron mentioned this pull request Oct 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@mboes mboes Awaiting requested review from mboes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tricktron @Profpatsch