Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asterisk: Bump all packages #99961

Merged
merged 1 commit into from Oct 9, 2020
Merged

asterisk: Bump all packages #99961

merged 1 commit into from Oct 9, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Oct 7, 2020

All packages were outdated.
Asterisk 15 is not supported anymore, but there is 17 now.

All versions bumped pjproject to 2.10 which requires overriding the
prefix.

Since Asterisk 17, make install-headers seems to be needed.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
asterisk: Bump all packages
c5e8dbc 
All packages were outdated.
Asterisk 15 is not supported anymore, but there is 17 now.

All versions bumped pjproject to 2.10 which requires overriding the
prefix.

Since Asterisk 17, `make install-headers` seems to be needed.
@ofborg ofborg bot requested review from yorickvP and DerTim1 October 7, 2020 16:14
DerTim1
DerTim1 approved these changes Oct 8, 2020
View reviewed changes
Copy link

@DerTim1 DerTim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

PR seems Ok. We may be able to test Asterisk 17 in a few weeks, but don't wait for it.

@ajs124 ajs124 merged commit 178213f into NixOS:master Oct 9, 2020
@ajs124 ajs124 deleted the upd/asterisk branch October 9, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 approved these changes

@DerTim1 DerTim1 DerTim1 approved these changes

@yorickvP yorickvP Awaiting requested review from yorickvP

Assignees
No one assigned
Labels
1.severity: security 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dasJ @ajs124 @DerTim1