Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gamehub: init at 0.16.0-1 #99957

Closed
wants to merge 7 commits into from
Closed

gamehub: init at 0.16.0-1 #99957

wants to merge 7 commits into from

Conversation

pasqui23
Copy link
Contributor

@pasqui23 pasqui23 commented Oct 7, 2020 •
edited

Motivation for this change

Gamehub is a game launcher supporting Steam,GOG and Humble Bundle

Things done

Compiles,but it cores dump with:

nix shell .#gamehub -c gamehub   
Gtk-Message: 16:03:18.564: Failed to load module "appmenu-gtk-module"
zsh: trace trap (core dumped)  nix shell .#gamehub -c gamehub
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pasqui23
Copy link
Contributor Author

pasqui23 commented Oct 8, 2020

@LouisDK1 would #95412 help here?

@LouisDK1
Copy link
Contributor

LouisDK1 commented Oct 8, 2020

@LouisDK1 would #95412 help here?

Yes it would. I'll try to make time to the fix up that pull request.

@SuperSandro2000 SuperSandro2000 changed the title gamehub: init at 0.16.0-1 [WIP] [WIP] gamehub: init at 0.16.0-1 Nov 27, 2020
@pasqui23 pasqui23 marked this pull request as ready for review March 6, 2021 10:34
@pasqui23 pasqui23 changed the title [WIP] gamehub: init at 0.16.0-1 gamehub: init at 0.16.0-1 Mar 6, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/485

SuperSandro2000
SuperSandro2000 requested changes Mar 21, 2021
View reviewed changes
pkgs/games/gamehub/default.nix Outdated Show resolved Hide resolved
pkgs/games/gamehub/default.nix Outdated Show resolved Hide resolved
pkgs/games/gamehub/default.nix Outdated Show resolved Hide resolved
pkgs/games/gamehub/default.nix Outdated Show resolved Hide resolved
pkgs/games/gamehub/default.nix Outdated Show resolved Hide resolved
pkgs/games/gamehub/default.nix Outdated Show resolved Hide resolved
SuperSandro2000
SuperSandro2000 requested changes Apr 5, 2021
View reviewed changes
pkgs/games/gamehub/default.nix Outdated Show resolved Hide resolved
pkgs/games/gamehub/default.nix Outdated Show resolved Hide resolved
@pasqui23 @SuperSandro2000
gamehub:fix typo
6c724ad 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
SuperSandro2000
SuperSandro2000 requested changes Apr 5, 2021
View reviewed changes
pkgs/games/gamehub/default.nix
wrapGAppsHook

];
propagatedBuildInputs = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the usage of propagatedBuildInputs here is correct. Libraries which are linked against should go to buildInputs. Executables which are needed at runtime should be made available using makeWrapper.

@RPGHank RPGHank mentioned this pull request Jun 22, 2021
Closed
@pasqui23
Copy link
Contributor Author

Ok, I can't build gamehub anymore somehow and I don't have interest in building it

@pasqui23 pasqui23 closed this Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcbravo tcbravo tcbravo left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pasqui23 @LouisDK1 @nixos-discourse @SuperSandro2000 @tcbravo