Add support for the Lenovo Thinkpad L14 (AMD) laptop #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blitz
changed the title
Mic92
reviewed
Oct 12, 2020
Mic92
reviewed
Oct 12, 2020
lenovo/thinkpad/l14-amd/default.nix
Outdated
| { | ||
| imports = [ | ||
| ../. | ||
| ../../../common/cpu/amd |
There was a problem hiding this comment.
Could their be a generic l14 module that gets extended by the more specific amd profile?
There was a problem hiding this comment.
So I've created l14/amd and l14/intel. I've populated the l14/intel profile with the same content as the l13 profile, because its basically the same laptop in a smaller chassis, but I couldn't test it.
Add support for the Lenovo Thinkpad L14 Gen 1 Intel and AMD variants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Lenovo Thinkpad L14 Gen 1 laptop with AMD Ryzen CPU (Renoir).
I'm not 100% sure where to put the module. If some one has a better idea than
l14-amdI'm all ears. Should it bel14/amdinstead?