Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-providers.cloudfoundry: init at 0.12.4 #99960

Merged
merged 1 commit into from Oct 29, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 7, 2020

Motivation for this change

Adds cloudfoundry terraform provider.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@timstott timstott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. A couple minor comments.

@risicle risicle force-pushed the ris-terraform-cloudfoundry-provider branch from 2346777 to 43dcab8 Compare October 27, 2020 19:43
Copy link
Contributor

@timstott timstott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✔️

# terraform 0.13
# main.tf
terraform {
  required_providers {
    cloudfoundry = {
      source = "cloudfoundry-community/cloudfoundry"
      version = "0.12.6"
    }
  }
}

provider "cloudfoundry" {}
[nix-shell:~/.cache/nixpkgs-review/pr-99960-2]$ nix-shell -p 'terraform_0_13.withPlugins(p: [p.cloudfoundry])'
these derivations will be built:
  /nix/store/26y1kv0wqc6mfp873yg0z52fyfq8djak-terraform-0.13.5.drv
building '/nix/store/26y1kv0wqc6mfp873yg0z52fyfq8djak-terraform-0.13.5.drv'...
[nix-shell:~/.cache/nixpkgs-review/pr-99960-2]$ terraform init

Initializing the backend...

Initializing provider plugins...
- Finding cloudfoundry-community/cloudfoundry versions matching "0.12.6"...
- Installing cloudfoundry-community/cloudfoundry v0.12.6...
- Installed cloudfoundry-community/cloudfoundry v0.12.6 (unauthenticated)

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

@zimbatm zimbatm merged commit 1b5ee95 into NixOS:master Oct 29, 2020
anandsuresh pushed a commit to anandsuresh/nixpkgs that referenced this pull request Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants